-
Notifications
You must be signed in to change notification settings - Fork 9
Derivatives with respect to parameters #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: derivatives
Are you sure you want to change the base?
Conversation
1. Agnostic about the structure of kwargs (which is the same of the output derivatives of the models): It can be a nested structure. 2. To address it, _apply applies a function to the leaf of nested dictionaries and lists 3. Drafted derivatives for CorrelatedFactorizedCrossSpectrum, Join 4. Derivatives wrt to multipoles are compressed from (ell, ..., ell) to (ell, ..., 1). This saves a lot of memory and operations, but may lead to mistakes. We have to decide whether it is worthwhile 5. Relatively minor changes here and there which, however, might break some compatibility with external codes 6. Only the variables should be passed to diff (i.e., those that are None in the defaults) and returned in the output dictionary/list
|
Minor fixes in frequency.py and power.py. Still need to look at cross.py. |
|
Had to revert to previous implementation of 4) for now. I have tested everything else and it's working as before. Need to complete the implementation of CorrelateFactorizesCrossSpectrum. |
…ctraAndCovariance.
output derivatives of the models): It can be a nested structure.
dictionaries and lists
to (ell, ..., 1). This saves a lot of memory and operations, but
may lead to mistakes. We have to decide whether it is worthwhile
some compatibility with external codes
None in the defaults) and returned in the output dictionary/list