Skip to content

Conversation

@gran-jlberrocal
Copy link

No description provided.

Copy link
Contributor

@tiffanyhardin tiffanyhardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jose,

This looks really good. Most of the assignments are correct.

I left some comments inline in the code for items you should address. This is how we usually review each others' work, so I wanted you to get used to this format.

I'll work on fixing the outdated placeholder image links throughout the bootcamp.

Thanks, Tiffany

Copy link
Contributor

@tiffanyhardin tiffanyhardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jose,

Thanks for making those updates, you got almost everything.

  • When going through the code review feedback, please don't mark conversations as resolved. The reviewer should do that after checking again.
  • Week 1.1 - HTML/4. Mock Up a Design/index.html
    My main point for this one was to use headers in order of h1, h2, h3 without skipping a level. Yours has h1, h3, and h4. You don't need to change it, but please remember that for the future.
  • Week 1.2 - CSS/6. Tricks - Click Passthrough/index.html
    Changing the position from absolute to relative hides the overlay altogether, which incorrectly modifies the original design. Instead, add this: pointer-events: none;

Thanks, Tiffany

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants