-
Notifications
You must be signed in to change notification settings - Fork 21
Jose Berrocal - Bootcamp solutions #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tiffanyhardin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jose,
This looks really good. Most of the assignments are correct.
I left some comments inline in the code for items you should address. This is how we usually review each others' work, so I wanted you to get used to this format.
I'll work on fixing the outdated placeholder image links throughout the bootcamp.
Thanks, Tiffany
fix issues found during code review process
tiffanyhardin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jose,
Thanks for making those updates, you got almost everything.
- When going through the code review feedback, please don't mark conversations as resolved. The reviewer should do that after checking again.
- Week 1.1 - HTML/4. Mock Up a Design/index.html
My main point for this one was to use headers in order of h1, h2, h3 without skipping a level. Yours has h1, h3, and h4. You don't need to change it, but please remember that for the future. - Week 1.2 - CSS/6. Tricks - Click Passthrough/index.html
Changing the position from absolute to relative hides the overlay altogether, which incorrectly modifies the original design. Instead, add this: pointer-events: none;
Thanks, Tiffany
No description provided.