Maria Herrera - Bootcamp Activities #112
Conversation
Files updated 3/11
|
Week 2.2 Flexbox |
| <!-- Slide 11 --> | ||
| <div class="slide" style="background-image: url('https://placehold.co/1024x720');"> | ||
| <div class="slide-content"> | ||
| <h1><strong>Phase 4:</strong></h1> |
There was a problem hiding this comment.
For a usual site structure, we wouldn't or shouldn't be using an h1 here as it disrupts the logical order of the page. H1s should be for the primary heading of the page. Here, the h1 heading is following the h2 headings of the previous slides.
There was a problem hiding this comment.
Thanks for clearing up the h1 usage, I was a bit unsure about it too!
There was a problem hiding this comment.
This is more of a note than a correction, when structuring content for a widget, we wouldn't typically lay out the content to bold text via <strong> elements, and handle that via CSS instead.
That said, your use of them isn't incorrect here. It was just worth noting since, when building a widget on one of our sites, the code reviewer may send it back to have you bold the text via CSS rather than using the <strong> element.
There was a problem hiding this comment.
Got it, I appreciate the clarification.
| <style> | ||
| /* Update the following line of CSS to only style `<p>` that follow an `<h2>` */ | ||
| p { | ||
| h2 ~ p { |
There was a problem hiding this comment.
One could argue that the instructions isn't fully clear though, depending on how you interpret that sentence, but this is the general sibling selector. h2 ~ p would select all the next p elements after an h2 rather than only p elements that follow an h2.
My counter argument here would be that, if you look at your file here, all of the <p> elements are being affected by this styling and not only the one that follows the <h2>. For example, some of the <p> are following another <p>, one of them is following an <h3>, etc.
2 participants
Week 1.1 HTML, Week 1.2 CSS, 1.3 JavaScript, Week 2.1 CSS Grid