-
Notifications
You must be signed in to change notification settings - Fork 21
Bernan Castillo - Bootcamp solutions #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test
Week 1.1. HTML Practice.
Bootcamp - 2 - CSS
Week 1.3 - JavaScript\1. Filter\index.html
Week 1.3 - JavaScript\2. Map\index.html
Week 1.3 - JavaScript
Week 2.1 - CSS Grid
Week 2.2 - Flexbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BernanGranicus ,
This looks good overall. I found some things that can be improved. Please let me know if you have any questions or want to discuss any of these.
Thanks, Tiffany
HTML 1.1 - 4. Mock Up a Design
The three lines of large text at the top (with Phase 4, Destination Thrive, Objective) should each be a different header tag. Destination Thrive should be the page h1 tag. The other two should be h2 and h3. There shouldn't be two h1 tags on a page, for SEO reasons.
CSS 1.2 - 4. Inheritance and Systems
Please re-read the instructions and update your code. The instructions say what css to use.
CSS 1.2 - 5. Transitions
Please re-read the instructions and update your code. There should be two different transition durations that apply to the .box when it's hovered and not hovered. There's also no need to add a new class to the button.
Javascript 1.3 - 3. Objects as a Map
Please move the declaration of const map outside of the function. It's most efficient to declare it once in the file instead of each time someone calls the function.
Flexbox 2.1 - 3. Placing Items - Advanced
Please don't use inline style attributes unless they're unavoidable. Also, remove the new classes like letter-e. Instead, update this to use nth-child selectors.
CMS Bootcamp Corrections
Bernan Castillo - Bootcamp solutions