Skip to content

Add and fix Rubocop (based on Rack 3 PR) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johnnyshields wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add and fix Rubocop (based on Rack 3 PR) #43

johnnyshields wants to merge 12 commits into from

Conversation

@johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented Aug 6, 2025 •
edited
Loading

This PR adds:

  • Add Rubocop
  • Add an extra integration testing spec
  • General code cleanup code

This PR is based on #42 for ease of review. You can either:

  • Merge this PR and close the other one (easier/better for me)
  • Merge the other PR first, then I'll rebase this one

Please enable Github Actions CI so tests can run. You can see passing tests here: https://github.com/johnnyshields/utf8-cleaner/actions/runs/16769723017

@johnnyshields johnnyshields mentioned this pull request Aug 6, 2025
Closed
@sbleon sbleon changed the base branch from master to main October 30, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@johnnyshields