Add retrocompatibility to java 6 and 7 #85
Conversation
Once we added support to java time I thing it's necessary to update the java compiler version
|
@mundodojava just make sure to check that, FF should continue working on previous compiler versions such as 1.6 and 1.7. Ty |
|
@mundodojava the build is broken... |
|
@mauriciojr I'm just updating tha java version compiler. Because we added support to Java Time. This change already broken the use with Java versions 1.6 and 1.7 . |
@mundodojava What does that mean? Are we affirming that every project wich has been using FF cannot update with the master version? Once you did that java.version runtime validation It doesn't make sense to me. If only java-8 compilers will be able to execute FF dependency, why validate they java.version? |
…a/fixture-factory into java-compiler-version Conflicts: pom.xml
|
Ok. I get your point. I added retrocompatibility to java 6 and 7. So validate java.version now makes sense. |
ismaelgcosta
changed the title
|
@nykolaslima Can you merge this? It will be necessary to this release. |
| Double value = Double.valueOf(i+(.23d)); | ||
| assertEquals("doubles should be equal", function.generateValue(), value); | ||
| } | ||
| } |
There was a problem hiding this comment.
@mundodojava could you explain the reason for these changes at NumberSequenceFunctionTest.java?
Did you find any issue with the autoboxing/unboxing usage?
Thank you!
There was a problem hiding this comment.
@mauriciojr Yes, when travis runs this test, it fails. The only way I found was that.
|
I`m waiting this merge and the new version to use at my work |
|
Hi guys, this PR will be merging? |
|
Hi @maurcarvalho @nykolaslima , can you merge this PR ? I fixed all the pointed changes |
3 participants
Once we added support to java time I thing it's necessary to update the java compiler version