minor fixes #7
Open
minor fixes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved creation of note_players and aliasing of nb.players to nb:init() to resolve error launching nb.lua demo script multiple times. - fixed issue with description>>name field not being populated with MIDI v port name - fixed typo in `voice_mod_targets` - modified sorting of players to handle uppercase names - added nb:stop_all() to cleanup() fn in nb.lua
- When saving and loading a pset, text params can be inadvertently converted from strings to numbers. - This results in a player name like "1.1" being added to nb_player_refcounts with a num index rather than string index, preventing the player:active()/inactive() functions from firing as expected. - This fix just forces the text param value to always be a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voice_mod_targets