[Dependency] Bump RainbowGrades from v23.06.01 to v1.0.14 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
a2a995e to
0c4b587
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
0c4b587 to
aacf8e8
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
aacf8e8 to
2356cff
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
2356cff to
5cf6033
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
5cf6033 to
40fd1c6
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
40fd1c6 to
426b1e9
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
426b1e9 to
e960c20
Compare
skara9
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Wrote test for manage students * Created a part that undos the first part and preliminary for student photos * All tests done! just need to make them better * Linting * removed calling of uneccessary id * Finished all tests! * Removed added id to toggle columns * Lint * Addressed william's comments #1 * Addressed william's comments #2 * Addressed william's comments #3 * More specific ids * Added test to see if pronouns changed on student page * Addressed Cameron's comments * unneccessary ; * Addressed William's comments regarding before() and after() --------- Co-authored-by: Cameron Peterson <46759635+IDzyre@users.noreply.github.com>
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
e960c20 to
7e1d811
Compare
skara9
changed the title
skara9
force-pushed
the
repo-up/RainbowGrades
branch
from
7e1d811 to
57fb409
Compare
skara9
pushed a commit
that referenced
this pull request
Jul 9, 2024
…#10389) When Exam Seating is misconfigured (files missing, named incorrectly, values incorrect) we get crashes (Frog Robot) instead of more helpful error messages. Here's one specific error that will be fixed with this PR change ``` TypeError (Code: 0) thrown in /usr/local/submitty/site/app/views/NavigationView.php (Line 152) by: if (property_exists($user_seating_details, 'building') && property_exists($user_seating_details, 'room')) { Message: property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given ``` --------- Co-authored-by: Barb Cutler <Barb Cutler>
|
This PR has been inactive (no commits and no review comments) for 12 days. If there is no new activity in the next 48 hours, this PR will be labeled as Abandoned PR - Needs New Owner and either another developer will finish the PR or it will be closed. |
skara9
pushed a commit
that referenced
this pull request
Oct 22, 2024
…0979) ### What is the current behavior? Jupyter notebook rendering errors have been reported on production due to Jupyter notebooks using string values instead of array values for some fields. For example: ``` TypeError (Code: 0) thrown in /usr/local/submitty/site/app/libraries/NotebookUtils.php (Line 26) by: 'markdown_data' => implode($cell['source']), Message: implode(): Argument #1 ($pieces) must be of type array, string given . . . ``` ### What is the new behavior? This PR fixes the issue by handling an array if an array value is submitted, and casting to a string otherwise.
lavalleeale
pushed a commit
that referenced
this pull request
Jun 6, 2025
…tty#11438) ### Please check if the PR fulfills these requirements: * [ ] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant * [ ] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? Closes Submitty#11430 ``` 12:02:39 02/04/2025 - FATAL ERROR Error (Code: 0) thrown in /usr/local/submitty/site/app/entities/email/EmailEntity.php (Line 95) by: return $this->term; Message: Typed property app\entities\email\EmailEntity::$term must not be accessed before initialization Stack Trace: #0 /usr/local/submitty/site/app/views/email/EmailStatusView.php(41): app\entities\email\EmailEntity->getTerm() #1 unknown file(unknown line): app\views\email\EmailStatusView->renderStatusPage() #2 /usr/local/submitty/site/app/libraries/Output.php(251): call_user_func_array() #3 /usr/local/submitty/site/app/libraries/Output.php(220): app\libraries\Output->renderTemplate() #4 /usr/local/submitty/site/app/libraries/response/WebResponse.php(43): app\libraries\Output->renderOutput() Submitty#5 /usr/local/submitty/site/public/index.php(160): app\libraries\response\WebResponse->render() USER: submitty-admin URL: https://submitty.cs.rpi.edu//superuser/email_status_page?csrf_token=a73dc648cdff817faba856852b2c75d5&page=1 ``` ### What is the new behavior?  We can see the email status ### Other information? How to Test: login as superuser send an email check email status page
lavalleeale
pushed a commit
that referenced
this pull request
Jun 6, 2025
### Please check if the PR fulfills these requirements: * [ ] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant * [ ] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? Upload a file to course materials, e.g., x.pdf Click the pencil next to the course material file to edit the course material. We can successfully edit the filename and/or the directory of the file, as long as we use a relative path. E.g., we can change the file name to "foo/y.pdf" and it adds a subdirectory named foo and changes the name of the file. We CANNOT start with the root directory, we cannot successfully edit it to "/bar/z.pdf". This causes a popup error at the attempt to edit, and all future attempts to even view the course materials page are broken. Here is the frog robot: Oh no! Something irrecoverable has happened... TypeError (Code: 0) thrown in /usr/local/submitty/site/app/views/course/CourseMaterialsView.php (Line 133) by: $path_to_place = array_slice($path_to_place, 0, $index, true) + Message: array_slice(): Argument #1 ($array) must be of type array, null given Stack Trace: #0 /usr/local/submitty/site/app/views/course/CourseMaterialsView.php(133): array_slice() #1 unknown file(unknown line): app\views\course\CourseMaterialsView->listCourseMaterials() #2 /usr/local/submitty/site/app/libraries/Output.php(251): call_user_func_array() #3 /usr/local/submitty/site/app/libraries/Output.php(220): app\libraries\Output->renderTemplate() #4 /usr/local/submitty/site/app/libraries/response/WebResponse.php(43): app\libraries\Output->renderOutput() Submitty#5 /usr/local/submitty/site/public/index.php(160): app\libraries\response\WebResponse->render() USER: instructor https://github.com/user-attachments/assets/3c0ceb7b-a03c-42e3-b62f-dccdf055b309 ### What is the new behavior?  ### Other information? closes Submitty#11476
lavalleeale
added a commit
that referenced
this pull request
Jun 23, 2025
### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> The edit gradable page displays numerous console errors during the initial load and when the window is resized. While functionality remains mostly intact, some users, particularly on Chrome, have reported issues with broken sidebar rendering, which is caused by TA grading parameters being applied to this specific page as well. ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> The following errors are the ones I was able to capture and address within this patch, which display occasionally on the main branch and shouldn't be shown anymore when the editable page is initially loaded or resized. Many type errors and deprecated warnings have been addressed, such as moving away from `DOMSubtreeModified` and `window.onunload`. Additionally, the full-screen mode should no longer be applied within this page. ``` [Error] [Deprecation] Listener added for a 'DOMSubtreeModified' mutation event. Support for this event type has been removed, and this event will no longer be fired. See https://chromestatus.com/feature/5083947249172480 for more information. add @ jquery.min.js?v=1750335357:2 (anonymous) @ jquery.min.js?v=1750335357:2 each @ jquery.min.js?v=1750335357:2 each @ jquery.min.js?v=1750335357:2 Le @ jquery.min.js?v=1750335357:2 on @ jquery.min.js?v=1750335357:2 (anonymous) @ update?nav_tab=0:2243 Promise.then (anonymous) @ update?nav_tab=0:2242 Promise.then (anonymous) @ update?nav_tab=0:2241 e @ jquery.min.js?v=1750335357:2 t @ jquery.min.js?v=1750335357:2 setTimeout (anonymous) @ jquery.min.js?v=1750335357:2 c @ jquery.min.js?v=1750335357:2 fireWith @ jquery.min.js?v=1750335357:2 fire @ jquery.min.js?v=1750335357:2 c @ jquery.min.js?v=1750335357:2 fireWith @ jquery.min.js?v=1750335357:2 ready @ jquery.min.js?v=1750335357:2 P @ jquery.min.js?v=1750335357:2 [Error] admin-gradeable-upda…js?v=1750336026:438 Failed to parse response from server: [object Object] "<br /> [Server Response] <b>Deprecated</b>: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in <b>/usr/local/submitty/site/app/controllers/admin/AdminGradeableController.php</b> on line <b>1783</b><br /> <br /> <b>Deprecated</b>: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in <b>/usr/local/submitty/site/app/controllers/admin/AdminGradeableController.php</b> on line <b>1786</b><br /> { "status": "success", "data": true }" [Error] Uncaught (in promise) ReferenceError: reloadInstructorEditRubric is not defined at update?nav_tab=0:2242:13 [Deprecated Feature Issue] Unload event listeners are deprecated and will be removed. 1 source (unknown) ``` Before (full screen mode persistence)  After  ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Visit the edit gradeable page on the main branch 2. Notice console errors and browser-specific issues when loading and resizing the page 3. Visit the same page on this branch 4. Notice no console errors (outside of flatpickr for Chrome) 5. For full-screen mode verification, toggle the mode within a grading panel page, then revisit the edit gradeable page to see no UI rendering issues ### Automated Testing & Documentation <!-- Is this feature sufficiently tested by unit tests and end-to-end tests? If this PR does not add/update the necessary automated tests, write a new GitHub issue and link it below. Is this feature sufficiently documented on submitty.org? Link related PRs or new GitHub issue to update documentation. --> N/A ### Other information <!-- Is this a breaking change? Does this PR include migrations to update existing installations? Are there security concerns with this PR? --> I keep getting the following error on Chrome, specifically within this page, but when I compare the DOM structure across different browsers, Chrome tends to have a completely different structure. Addressing this issue is outside the scope of this PR and should be addressed in a future one. ``` [Error] TypeError: Cannot read properties of undefined (reading 'appendChild') at Object.onReady (index.ts:169:38) at De (flatpickr.min.js?v=1750335357:2:35446) at flatpickr.min.js?v=1750335357:2:49325 at k (flatpickr.min.js?v=1750335357:2:49339) at T (flatpickr.min.js?v=1750335357:2:49626) at I (flatpickr.min.js?v=1750335357:2:50016) at HTMLDocument.<anonymous> (update?nav_tab=1:5531:9) at e (jquery.min.js?v=1750335357:2:27028) at t (jquery.min.js?v=1750335357:2:27330) ``` --------- Co-authored-by: Alex Lavallee <alex@lavallee.one>
skara9
pushed a commit
that referenced
this pull request
Sep 30, 2025
…11981) ### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> Submitty#11702 Magic Methods PR stated that team_lock_date is ?DateTime, which is true, but getting the value actually returns a DateTime, casuing a frog robot crash ``` Oh no! Something irrecoverable has happened... app\exceptions\OutputException (Code: 0) thrown in /usr/local/submitty/site/app/libraries/Output.php (Line 412) by: throw new OutputException("{$e->getMessage()} in {$e->getFile()}:{$e->getLine()}"); Message: An exception has been thrown during the rendering of a template ("app\models\gradeable\Gradeable::getTeamLockDate(): Return value must be of type DateTime, null returned") in "admin/admin_gradeable/AdminGradeableDates.twig" at line 14. in /usr/local/submitty/site/app/templates/admin/admin_gradeable/AdminGradeableDates.twig:14 Stack Trace: #0 /usr/local/submitty/site/app/libraries/Output.php(425): app\libraries\Output->renderTwigTemplate() #1 /usr/local/submitty/site/app/controllers/admin/AdminGradeableController.php(617): app\libraries\Output->renderTwigOutput() #2 /usr/local/submitty/site/app/controllers/admin/AdminGradeableController.php(32): app\controllers\admin\AdminGradeableController->editPage() #3 unknown file(unknown line): app\controllers\admin\AdminGradeableController->editGradeableRequest() #4 /usr/local/submitty/site/app/libraries/routers/WebRouter.php(254): call_user_func_array() Submitty#5 /usr/local/submitty/site/app/libraries/routers/WebRouter.php(232): app\libraries\routers\WebRouter->run() Submitty#6 /usr/local/submitty/site/public/index.php(147): app\libraries\routers\WebRouter::getWebResponse() USER: instructor ``` ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> Like all other dates, team lock date now returns the correct value, `?\DateTime` ### What steps should a reviewer take to reproduce or test the bug or new feature? ### Automated Testing & Documentation <!-- Is this feature sufficiently tested by unit tests and end-to-end tests? If this PR does not add/update the necessary automated tests, write a new GitHub issue and link it below. Is this feature sufficiently documented on submitty.org? Link related PRs or new GitHub issue to update documentation. --> We should check creating and modifying dates for a checkpoint gradeables Submitty#11982 11982 ### Other information <!-- Is this a breaking change? Does this PR include migrations to update existing installations? Are there security concerns with this PR? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps RainbowGrades from v23.06.01 to v1.0.14.
See release notes