Skip to content

Conversation

@smilingprogrammer
Copy link
Contributor

@smilingprogrammer smilingprogrammer commented Dec 2, 2025

Reference Issues/PRs

Fix for #283

What does this implement/fix? Explain your changes.

  • Empirical.sample now honors time_indep: scalar distributions still delegate to the base implementation, but multidimensional ones keep entire time series intact when time_indep=False and behave exactly as before when True.
  • Added a row_indep flag (default True) so users can couple or decouple rows independently of the time axis; adaptered it also to QPD_Empirical

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

correctness of implementation

Did you add any tests for the change?

Not yet. Need initial review before proceeding to add a test.

Any other comments?

This is an initial fix towards resolving issue #283. After initial review, we can proceed to re-iterate for improvement and add a test.

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@smilingprogrammer smilingprogrammer changed the title Resolve ->[ENH] issues and features for the Empirical distribution [ENH] issues and features for the Empirical distribution Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant