Skip to content

Conversation

@n-hidaka
Copy link
Contributor

@n-hidaka n-hidaka commented Dec 3, 2025

This pull request upgrades the SkyWay SDK from version 1.x to 2.x and refactors the codebase to use the new unified Room and LocalRoomMember types introduced in the SDK. The changes also update the room initialization and media publishing logic to match the new API, simplifying the handling of room modes and stream encoding options.

SDK Upgrade and API Refactor:

  • Upgraded @skyway-sdk/room dependency from ^1.15.2 to ^2.0.0 in package.json, enabling use of the new SDK features and types.
  • Refactored all room and member types to use the new unified Room and LocalRoomMember types, replacing legacy P2PRoom, SfuRoom, LocalP2PRoomMember, and LocalSFURoomMember throughout the codebase (src/conference/effects/room.ts, src/conference/stores/room.ts, src/conference/utils/skyway.ts). [1] [2] [3]
  • Corrected configuration property from updateReminderSec to updateRemindSec in config options.

Room Initialization and Joining:

  • Updated room creation logic to use type: "default" instead of distinguishing between "sfu" and "p2p", and changed join methods to use the new member types. [1] [2]

Media Publishing and Subscription Logic:

  • Refactored publishAudio, publishVideo, and subscribe functions to use the new API, passing room mode explicitly and updating encoding options based on whether the mode is "SFU" or "p2p". [1] [2] [3] [4] [5]

@n-hidaka n-hidaka merged commit 5e9f86f into main Dec 3, 2025
1 check passed
@n-hidaka n-hidaka deleted the chore/update-room-package-version-2 branch December 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants