Skip to content

Correctly handle different javascript realms/documents #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edave64 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correctly handle different javascript realms/documents #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c46366
Correctly detect elements coming from different realms
edave64 Jul 18, 2024
e4bb670
Handle contained by checks in documents other than the primary document
edave64 Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/blot/abstract/parent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ class ParentBlot extends ShadowBlot implements Parent {
node.parentNode != null &&
// @ts-expect-error Fix me later
node.tagName !== 'IFRAME' &&
document.body.compareDocumentPosition(node) &
(node.ownerDocument ?? document).body.compareDocumentPosition(node) &
Node.DOCUMENT_POSITION_CONTAINED_BY
) {
return;
Expand Down
6 changes: 5 additions & 1 deletion src/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ export default class Registry implements RegistryInterface {
} else if (query & Scope.LEVEL & Scope.INLINE) {
match = this.types.inline;
}
} else if (query instanceof Element) {
} else if (
query instanceof HTMLElement ||
query instanceof
(query.ownerDocument?.defaultView?.HTMLElement ?? HTMLElement)
) {
const names = (query.getAttribute('class') || '').split(/\s+/);
names.some((name) => {
match = this.classes[name];
Expand Down