-
-
Notifications
You must be signed in to change notification settings - Fork 73
Migrate Danger to danger-pr-comment #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+29
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
213faea to
1dcc80b
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1dcc80b to
fe962f7
Compare
dblock
added a commit
to dblock/slack-ruby-bot-server-events-app-mentions
that referenced
this pull request
Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/slack-ruby-bot-server-events-app-mentions
that referenced
this pull request
Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/slack-ruby-bot-server-events-app-mentions
that referenced
this pull request
Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/slack-ruby-bot-server-events-app-mentions
that referenced
this pull request
Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/slack-ruby-bot-server-events-app-mentions
that referenced
this pull request
Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger-entity
that referenced
this pull request
Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment gem - Add changelog.check! and toc.check! to Dangerfile - Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger-entity
that referenced
this pull request
Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment gem - Add changelog.check! and toc.check! to Dangerfile - Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger
that referenced
this pull request
Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
4 tasks
dblock
added a commit
to dblock/grape-swagger
that referenced
this pull request
Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger-entity
that referenced
this pull request
Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment gem - Add changelog.check! and toc.check! to Dangerfile - Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger
that referenced
this pull request
Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger
that referenced
this pull request
Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger
that referenced
this pull request
Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
added a commit
to dblock/grape-swagger-entity
that referenced
this pull request
Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment gem - Add changelog.check! and toc.check! to Dangerfile - Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
danger-pr-commentworkflow framework following slack-ruby/slack-ruby-client#581Gemfile.dangerdependencies into mainGemfile(addeddanger-changelog,danger-pr-comment,danger-toc)danger.yml(runs Danger checks) anddanger-comment.yml(posts results as PR comments)Dangerfileto importdanger-pr-commentgemGemfile.dangerandGemfile.danger.lockTest plan
🤖 Generated with Claude Code