Skip to content

Conversation

@dblock
Copy link
Collaborator

@dblock dblock commented Dec 30, 2025

Summary

  • Migrated from custom Danger setup to danger-pr-comment workflow framework following slack-ruby/slack-ruby-client#581
  • Consolidated Gemfile.danger dependencies into main Gemfile (added danger-changelog, danger-pr-comment, danger-toc)
  • Added two new workflow files: danger.yml (runs Danger checks) and danger-comment.yml (posts results as PR comments)
  • Updated Dangerfile to import danger-pr-comment gem
  • Removed Gemfile.danger and Gemfile.danger.lock

Test plan

  • Verify Danger workflow runs successfully on this PR
  • Verify Danger comment is posted to this PR
  • Verify all Danger checks pass

🤖 Generated with Claude Code

@dblock dblock force-pushed the migrate-danger-pr-comment branch 2 times, most recently from 213faea to 1dcc80b Compare December 30, 2025 18:32
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock force-pushed the migrate-danger-pr-comment branch from 1dcc80b to fe962f7 Compare December 30, 2025 18:35
@dblock dblock merged commit 2e8c460 into slack-ruby:master Dec 30, 2025
19 checks passed
@dblock dblock deleted the migrate-danger-pr-comment branch December 30, 2025 18:37
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant