Improve error handling for expired Mesh V2 groups #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add client-side validation for expired groups before joining - Pass disconnect reason to disconnect callback - Handle GroupNotFound and expired reasons by setting connection state to error - Capture expiresAt from joinGroup result - Add unit tests for expired group scenarios Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a member attempts to join an expired Mesh V2 group, the connection now properly transitions to an error state instead of briefly showing success and then silently disconnecting.
Changes
connect()to prevent joining groups that have already expired based on theirexpiresAttimestamp.MeshV2Serviceto pass error types (e.g.,GroupNotFound,Unauthorized) as reasons to the disconnect callback.errorwhen a group expires during operation or when a join attempt fails due to expiration.expiresAtfromjoinGroupresponse to prepare for future backend support.test/unit/extension_mesh_v2_issue66.jscovering these scenarios and updated existing tests to match the new API.Fixes #66