feat: use last modified value for meshV2 sensor value block #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update remoteData structure to include timestamps for each data key - Modify handleDataUpdate and fetchAllNodesData to store timestamps - Update getRemoteVariable to return most recently modified value - Add unit tests for timestamp-based variable retrieval - Update integration tests to match new remoteData structure Resolves: smalruby/smalruby3-gui#492 Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When multiple nodes have data with the same name (e.g., "my variable"), the meshV2 sensor value block should return the most recently modified value.
Proposed Changes
remoteDatastructure to include timestamps for each data key:{ nodeId: { key: { value: string, timestamp: number } } }handleDataUpdateandfetchAllNodesDatato storeDate.now()when receiving or fetching datagetRemoteVariableto iterate through all nodes and return the value with the largest timestamptest/unit/mesh_service_v2_timestamp.jsto verify the timestamp-based selection logictest/integration/extensions/mesh-v2-variable-sync.test.jsto match the newremoteDatastructureTest Coverage
test/unit/mesh_service_v2_timestamp.jstest/integration/extensions/mesh-v2-variable-sync.test.jsnpm testResolves: smalruby/smalruby3-gui#492