fix: clear AI save status when file save is cancelled or fails #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added onSaveError callback to RubyDownloader to handle save operation failures and cancellations. - Implemented handleAISaveError in MenuBar and RubyTab to reset the aiSaveStatus when triggered. - Added unit tests for RubyDownloader to ensure onSaveError is called correctly when the File System Access API rejects. Fixes #440 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…-clear-koshien-save-status fix: clear AI save status when file save is cancelled or fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the "ルビーを保存中..." (Saving Ruby...) progress indicator remained visible indefinitely if the user cancelled the file save dialog in the Smalruby Koshien menu.
Implementation Details
onSaveErrorprop that is called whenwindow.showSaveFilePickerrejects (e.g.,AbortErroron cancellation).handleAISaveErrorto clear the AI save status and passed it toRubyDownloader.Test Coverage
test/unit/containers/ruby-downloader.test.jsxto verifyonSaveErroris called when the save dialog is cancelled.npm run test:unit.npm run test:lint.Fixes #440