Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Dec 17, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The proposed changes make the following improvements:

  • Rename the directory and package from "myproject" to "chip_ingress" to better reflect the scope and purpose of the example.
  • Update the test file to use the new package name and adjust the import paths accordingly.
  • Introduce a new .tool-versions file specifying the Go language version, ensuring consistent development environments.
  • Update the go.mod and go.sum files to reflect the new module path and include necessary dependencies for the project.
  • Adjust the test functions to utilize the renamed SchemaSet and related function signatures, which likely offer enhancements or bug fixes relevant to the project.

These changes are aimed at improving project organization, maintaining dependency management, and ensuring compatibility with the Go language and third-party libraries.

What

  • Renamed the directory from myproject to chip_ingress.
  • Renamed related package and files to reflect the new directory name.
  • Introduced .tool-versions file specifying golang 1.25.3.
  • Updated go.mod and go.sum for the chip_ingress example with necessary dependencies.
  • Adjusted test functions to align with changes in the chipingressset package, particularly the renaming of ProtoSchemaSet to SchemaSet and the function DefaultRegisterAndFetchProtos to FetchAndRegisterProtos, along with parameter adjustments to match the new function signatures.

@Tofel Tofel requested a review from a team as a code owner December 17, 2025 07:36
Copilot AI review requested due to automatic review settings December 17, 2025 07:36
@github-actions
Copy link

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements schema registration using the Chip Config service instead of direct Schema Registry integration. The changes introduce a new chip-config Docker service and migrate from manual proto file processing to a Chip Config-based approach.

Key Changes:

  • Replaces direct Schema Registry schema registration with Chip Config service integration
  • Adds chip-config and postgres services to the Docker Compose stack
  • Simplifies proto file handling by delegating to Chip Config's schema management

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
smoke_chip_ingress_test.go Updates test to use new FetchAndRegisterProtos API with Chip Config
go.mod (examples) Adds Go 1.25.3 as the language version for the examples module
go.mod (dockercompose) Updates to Go 1.25.3 and adds Chip Config dependencies
protos.go Replaces schema registry logic with Chip Config-based registration
chip_config.go Adds new schema config parsing and validation functionality
chip_ingress.go Integrates Chip Config service into the Docker Compose stack
docker-compose.yml Adds chip-config and postgres services to the stack
.tool-versions Sets Go version to 1.25.3
framework-dockercompose-tests.yml Updates CI to use specific Chip Config image version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tofel Tofel force-pushed the prodcre-1522-register-protos-chip-ingress branch from 19f71f9 to 76ba530 Compare December 17, 2025 07:40
@Tofel Tofel force-pushed the prodcre-1522-register-protos-chip-ingress branch from 7b52323 to f0acf85 Compare December 17, 2025 11:59
skudasov
skudasov previously approved these changes Dec 18, 2025
@Tofel Tofel merged commit d093862 into main Dec 22, 2025
73 of 75 checks passed
@Tofel Tofel deleted the prodcre-1522-register-protos-chip-ingress branch December 22, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants