-
Notifications
You must be signed in to change notification settings - Fork 43
[PRODCRE-1522] register schemas using chip config #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ip ingress readiness before registering anything
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements schema registration using the Chip Config service instead of direct Schema Registry integration. The changes introduce a new chip-config Docker service and migrate from manual proto file processing to a Chip Config-based approach.
Key Changes:
- Replaces direct Schema Registry schema registration with Chip Config service integration
- Adds
chip-configandpostgresservices to the Docker Compose stack - Simplifies proto file handling by delegating to Chip Config's schema management
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| smoke_chip_ingress_test.go | Updates test to use new FetchAndRegisterProtos API with Chip Config |
| go.mod (examples) | Adds Go 1.25.3 as the language version for the examples module |
| go.mod (dockercompose) | Updates to Go 1.25.3 and adds Chip Config dependencies |
| protos.go | Replaces schema registry logic with Chip Config-based registration |
| chip_config.go | Adds new schema config parsing and validation functionality |
| chip_ingress.go | Integrates Chip Config service into the Docker Compose stack |
| docker-compose.yml | Adds chip-config and postgres services to the stack |
| .tool-versions | Sets Go version to 1.25.3 |
| framework-dockercompose-tests.yml | Updates CI to use specific Chip Config image version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
framework/components/dockercompose/chip_ingress_set/chip_config.go
Outdated
Show resolved
Hide resolved
19f71f9 to
76ba530
Compare
7b52323 to
f0acf85
Compare
…m:smartcontractkit/chainlink-testing-framework into prodcre-1522-register-protos-chip-ingress
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The proposed changes make the following improvements:
.tool-versionsfile specifying the Go language version, ensuring consistent development environments.go.modandgo.sumfiles to reflect the new module path and include necessary dependencies for the project.SchemaSetand related function signatures, which likely offer enhancements or bug fixes relevant to the project.These changes are aimed at improving project organization, maintaining dependency management, and ensuring compatibility with the Go language and third-party libraries.
What
myprojecttochip_ingress..tool-versionsfile specifyinggolang 1.25.3.go.modandgo.sumfor thechip_ingressexample with necessary dependencies.chipingresssetpackage, particularly the renaming ofProtoSchemaSettoSchemaSetand the functionDefaultRegisterAndFetchProtostoFetchAndRegisterProtos, along with parameter adjustments to match the new function signatures.