Skip to content

datetime exception fix #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleswita merged 1 commit into from
May 19, 2025
Merged

datetime exception fix #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/DateTimes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ final public static function from(
}
}

throw new InvalidTypeException(
'Value ' . $value . ' must be string in ' . DateTimeFormat::DATETIME . ' format'
);
throw InvalidTypeException::typeError(DateTimeFormat::DATETIME . ' format', $value);
}

/**
Expand Down
4 changes: 1 addition & 3 deletions src/Dates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ final public static function from(
}
}

throw new InvalidTypeException(
'Value ' . $value . ' must be string in ' . DateTimeFormat::DATE . ' format'
);
throw InvalidTypeException::typeError(DateTimeFormat::DATE . ' format', $value);
}

/**
Expand Down
13 changes: 13 additions & 0 deletions tests/DateTimesTest.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,19 @@ final class DateTimesTest extends TestCase
InvalidTypeException::class
);

Assert::throws(
static function (): void {
DateTimes::from(
[
'date' => '1979-02-23 00:00:00.000000',
'timezone' => 'Europe/Prague',
'timezone_type' => 3,
]
);
},
InvalidTypeException::class
);

$d = DateTimes::from('2000-01-01 00:00:00.123456');
Assert::equal('2000-01-01 00:00:00', DateTimeFormatter::format($d));

Expand Down
13 changes: 13 additions & 0 deletions tests/DatesTest.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ final class DatesTest extends TestCase
},
InvalidTypeException::class
);

Assert::throws(
static function (): void {
Dates::from(
[
'date' => '1979-02-23 00:00:00.000000',
'timezone' => 'Europe/Prague',
'timezone_type' => 3,
]
);
},
InvalidTypeException::class
);
}

public function testExtract(): void
Expand Down