OSDP File Transfers

[LivInAbsurdism]

No description provided.

[Copilot]

Pull Request Overview

Adds OSDP file transfer support by implementing file transfer command chunking, FTSTAT reply decoding, and a high-level file_transfer API with tests.

• Introduce Jeff.Command.FileTransfer with command_set/2, adjust_from_reply/2, and private chunking logic
• Add Jeff.Reply.FileTransferStatus decoder and integrate it into Jeff.Reply.decode/2
• Provide Jeff.file_transfer/3|4 public API, progress callbacks, and end-to-end tests

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/command/file_transfer_test.exs	New tests for command_set/2 and adjust_from_reply/2
lib/jeff/reply/file_transfer_status.ex	Define FileTransferStatus struct & decode/1 logic
lib/jeff/reply.ex	Register FTSTAT decode branch in the main reply dispatcher
lib/jeff/command/file_transfer.ex	Implement FileTransfer command struct, chunking, and adjust
lib/jeff/command.ex	Hook up FILETRANSFER encode path in the command router
lib/jeff.ex	Add `file_transfer/3
.mise.toml	Pin Elixir/Erlang versions

Comments suppressed due to low confidence (2)

test/command/file_transfer_test.exs:1

• [nitpick] Test module name doesn’t match its path; rename to Jeff.Command.FileTransferTest to align with test/command/file_transfer_test.exs.

defmodule Jeff.FileTransferTest do

lib/jeff/command/file_transfer.ex:74

• Typo in doc: change 'may need to been adjusted' to 'may need to be adjusted' for correct grammar.

  next set of commands may need to be adjusted or prevented and this provides

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[kybishop]

I'm admittedly glossing over this a bit but the general architecture seems sound. It seems to me that we'd know very quickly if something is wrong with the implementation during test so I'm not too concerned about reviewing with a fine toothed comb.

[jjcarstens]

Just some thoughts. Looks great!

[jjcarstens]

🎉