Update parser.js #11
Open
Update parser.js #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add support for UTF16. Detect the encoding by looking for the byte order mark at the start of the incoming buffer and save this as encoding for the rest of the incoming chunks. (https://en.wikipedia.org/wiki/Byte_order_mark) - other encodings could probably also be detected. Note: the encoding for the incoming chunk will be "buffer", so no use of using this as encoding when converting to string. 2. trim the name of the opening tag end the closing tag. Failed corner case found when tag is written as "<TagName >". the space between the tagname and end bracket '>' is emitted as the full tag name
Added proper support for utf16 big endian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.