Bug/tcp panic unrecovered blocking port

[hcliff]

I kept running into an issue where running the dredd cli in rapid succession failed on account of a port being in use.

anyway, this is the resulting pr, I worked through some docs as I came to understand the project, added some logging to debug and ultimately resolved my issue.

great project, would love to see more of dredd written in go!

This shouldn't break anything, more than happy to get involved and make changes as required though

[IngmarStein]

Hey @hcliff, did you see #23? It seems like we were running into the same issue and implemented the connection retry for the hooks server almost identically.

CC @snikch

[ddelnano]

sorry guys was out of town but I will look at #23 and this hopefully this week.

[hcliff]

@IngmarStein yup saw it, hope you don't mind but I cribbed some code (main.go:41), while this does make it more reliable I also wanted to address the underlying cause (unclean shutdown leaving running processes)

[IngmarStein]

Don't mind at all 👍 Did you find out why the tests are failing?

[hcliff]

nope, will dig in this week/end

[ddelnano]

@hcliff I found the issue with the tests. I pushed a fix here #25. It was related to the fact that you moved the Accept call into NewServer which blocks unless a client connects to it. There is still an issue because the refactor to cmd/goodman/main.go does not clean up after itself which is why the cucumber tests fail now. I am trying to work through that last issue.