[MIST-1131] Implement recovery-based scale out #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taegeonum
reviewed
May 22, 2018
Contributor
taegeonum
left a comment
taegeonum
left a comment
There was a problem hiding this comment.
I've left some comments. Thanks!
| "type": "double" | ||
| }, | ||
| { | ||
| "name": "NumEventProcessors", |
Contributor
There was a problem hiding this comment.
Why do we need this information?
Contributor
There was a problem hiding this comment.
Can't we send the group load info from Task by dividing the load by the number of event processors?
| innerList.add(taskHostname); | ||
| return innerMap.putIfAbsent(taskHostname, TaskStats.newBuilder() | ||
| .setTaskLoad(0.0) | ||
| .setNumEventProcessors(1) |
Contributor
There was a problem hiding this comment.
What happen if a task fails before it is updated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1131 via