fix build with clang-cl #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the build when using clang-cl (Clang's MSVC-compatible driver on Windows) by conditionally applying the appropriate RTTI flags based on whether MSVC mode is enabled.
- Adds conditional logic to use
/GR(MSVC-style flag) whenMSVCis true, and-frtti(GCC/Clang-style flag) when it's not - Updates the comment to reference both
-fno-rttiand/GR-as potential parent project flags
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sergio-nsk
force-pushed
the
sergey/SPTCH-3554/19
branch
from
e01b679 to
80d65ce
Compare
nmoinvaz
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.