[MultiAdaptiveBeamMapping] use Link instead of a string to set the controller #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: clean
pr: status to review
fredroy
force-pushed
the
change_irc_link_mapping
branch
from
44fc226 to
fa32cf2
Compare
hugtalbot
approved these changes
Nov 6, 2025
hugtalbot
added
pr: status ready
bakpaul
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so many wrong stuff here...
I renamed the attribute with the alias (which was always use) and set a compat layer.
The parse method will
So this PR will be breaking for compilation if one was using the deleted/renamed members but should not be breaking for runtime