-
Notifications
You must be signed in to change notification settings - Fork 52
Binding base camera #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jnbrunet
merged 35 commits into
sofa-framework:master
from
coolteemf:Binding_BaseCamera
May 20, 2021
Merged
Binding base camera #110
jnbrunet
merged 35 commits into
sofa-framework:master
from
coolteemf:Binding_BaseCamera
May 20, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean-ups before release * Swap the cmake dependent option SP3_LINK_TO_USER_SITE to a regular cmake option. * Missing SofaBaseLinearSolver in RestShapeForcefied test
* Build SofaPython3 alongside SofaPython because it's possible. * Keep only one ON-OFF option: PLUGIN_SOFAPYTHON3 * Use new macros from SofaMacros * Improve install tree * [cmake] Fix rpaths for both in-tree and out-of-tree * [cmake] Use a global cmake variable to set the RPath to all targets under the bindings directory Co-authored-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
(cherry picked from commit 475250a)
(cherry picked from commit 1b675c8)
* Add example to load XML file from python environment * Update scenes with pluginization * Missing plugin SofaOpenglVisual in scenes (cherry picked from commit e496cb1)
(cherry picked from commit e75afab)
* CLEAN SofaPython3Config.cmake.in * [cmake] Wider RPATH support for python modules
* [CMake] Simplify RPATH management * [CMake] Simplify RPATH management (2) * [CMake] Simplify RPATH management (3) * [CMake] Handle dep. to other python modules in RPATH * [CMake] CLEAN SofaPython3Tools.cmake
Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
…ngs (sofa-framework#97) The pygame example is broken and would necessitate to bring back a hard dependency on glew. Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Contributor
|
Hey @coolteemf , Thanks for these additions! Could you add the label "status: to review " once you have finished adding commits to your PR? |
Contributor
Author
|
Hello @jnbrunet |
…mework#116) Signed-off-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Contributor
|
What's up with this PR @coolteemf ? |
Contributor
Author
|
@hugtalbot Sorry for the long delay ^^' |
Contributor
Author
|
@jnbrunet I'm sorry I don't see a button to add a label... |
jnbrunet
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more bindings for camera methods.
The binded methods convert between screen pixel coordinates and word 3D coordinates.
These point conversion method should be the most useful among the other point conversion methods (e.g viewport/screen...)