Skip to content

Conversation

@guparan
Copy link
Contributor

@guparan guparan commented May 5, 2021

When Sofa.Components was activated, its test (bindings/Sofa/tests/Components/Components.py) was the first test executed.
This test contains a root.addObject('RequiredPlugin', name='SofaBaseMechanics').
Well, there is no Python environment cleaning between each test.
Thus SP3 tests benefit from the RequiredPlugin done by all the tests executed before.
That is why the deactivation of Sofa.Components made all those tests fail with "cannot create MechanicalObject".

What I did:

  • re-enable Sofa.Components (and its test) and move the test to be the last executed
  • fix all SP3 tests that use MechanicalObject with some "RequiredPlugin SofaBaseMechanics"

Copy link
Contributor

@jnbrunet jnbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @guparan ! This will get our CI back and running 👍

@jnbrunet jnbrunet merged commit 007e8db into sofa-framework:master May 5, 2021
@guparan guparan added this to the v21.06 milestone Oct 26, 2021
@guparan guparan deleted the fix_tests_mechanicalobject branch November 18, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants