-
Notifications
You must be signed in to change notification settings - Fork 52
[CMake] FIX pybind11 finding python (2) #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] FIX pybind11 finding python (2) #156
Conversation
|
CI here is not happy :-( |
|
|
|
With my latest commit, SOFA CI will fail PythonLibs should not be python 2.7 |
994fccf to
9099aa6
Compare
|
We should be good now @jnbrunet 👍 |
|
Hey @guparan Looks like the tests are failing on MacOS because numpy cannot be found. Numpy is installed as a requirement so this sounds like numpy as been installed on a python version different from the one used for the compilation. Does that rings a bell? |
|
SOFA minimal binaries do not include SP3 anymore but the workflows are fetching an old (always the same) version of the binaries. Maybe this is the cause? |
|
Hum here the tests are running using the SP3 built previously in the same workflow, not the one downloaded from SOFA. Looking quickly over your workflow result:
I'm not sure why python 3.9 is used here for the build job... It wasn't before your changes apparently. It seems to be ok on Linux however (3.7 is used both for building and testing). |
bbfe37c to
b5de9fe
Compare
f141b60 to
2cc8bda
Compare
|
@jnbrunet I'm done here too! Debug logs could be removed but it can wait another PR. |
jnbrunet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here, if you could just resolve the conflicts (I just merged #157) , I'll merge as soon as its done
…mat_error # Conflicts: # .github/workflows/macos.yml
|
Done 👌 |

TO BE SQUASHED
I thought PYTHON_EXECUTABLE was enough but apparently it's not with pybind11 2.4.3
See error in https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/master/CI_CONFIG=ubuntu_clang-6,CI_PLUGINS=options,CI_TYPE=release/2758/consoleFull