Skip to content

Conversation

@guparan
Copy link
Contributor

@guparan guparan commented Jul 28, 2021

TO BE SQUASHED

I thought PYTHON_EXECUTABLE was enough but apparently it's not with pybind11 2.4.3

See error in https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/master/CI_CONFIG=ubuntu_clang-6,CI_PLUGINS=options,CI_TYPE=release/2758/consoleFull

@guparan
Copy link
Contributor Author

guparan commented Jul 28, 2021

@jnbrunet
Copy link
Contributor

CI here is not happy :-(

@guparan
Copy link
Contributor Author

guparan commented Jul 28, 2021

cannot find -lpython3.7m
Why that? 😭

@guparan
Copy link
Contributor Author

guparan commented Jul 28, 2021

With my latest commit, SOFA CI will fail

--- find_package(Python) ---
-- Found Python: /usr/bin/python3.7 (found suitable version "3.7.5", minimum required is "3.7") found components:  Interpreter Development 
--- find_package(Python) done ---
--- find_package(pybind11) ---
-- Found PythonInterp: /usr/bin/python3.7 (found suitable version "3.7.5", minimum required is "3.7") 
-- Found PythonLibs: /usr/lib/python2.7/config-x86_64-linux-gnu/libpython2.7.so
--- find_package(pybind11) done ---

PythonLibs should not be python 2.7

@guparan guparan force-pushed the fix_fileformat_error branch from 994fccf to 9099aa6 Compare July 29, 2021 08:57
@guparan
Copy link
Contributor Author

guparan commented Jul 29, 2021

We should be good now @jnbrunet 👍

@jnbrunet
Copy link
Contributor

Hey @guparan

Looks like the tests are failing on MacOS because numpy cannot be found. Numpy is installed as a requirement so this sounds like numpy as been installed on a python version different from the one used for the compilation. Does that rings a bell?

@guparan
Copy link
Contributor Author

guparan commented Jul 29, 2021

SOFA minimal binaries do not include SP3 anymore but the workflows are fetching an old (always the same) version of the binaries. Maybe this is the cause?
If yes, #157 should solve that.

@jnbrunet
Copy link
Contributor

jnbrunet commented Jul 29, 2021

Hum here the tests are running using the SP3 built previously in the same workflow, not the one downloaded from SOFA.

Looking quickly over your workflow result:

  1. SP3 cmake shows that python 3.9 is used for building, even tho we set up version 3.7 for the job....
  2. SP3 test job is setting python to version 3.7, and is using this python version to download numpy

I'm not sure why python 3.9 is used here for the build job... It wasn't before your changes apparently. It seems to be ok on Linux however (3.7 is used both for building and testing).

@guparan guparan force-pushed the fix_fileformat_error branch from bbfe37c to b5de9fe Compare July 30, 2021 15:48
@guparan guparan force-pushed the fix_fileformat_error branch from f141b60 to 2cc8bda Compare July 30, 2021 17:10
@guparan
Copy link
Contributor Author

guparan commented Jul 30, 2021

@jnbrunet I'm done here too! Debug logs could be removed but it can wait another PR.
Let's merge, SOFA CI has been waiting this fix for too long!

Copy link
Contributor

@jnbrunet jnbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, if you could just resolve the conflicts (I just merged #157) , I'll merge as soon as its done

@guparan
Copy link
Contributor Author

guparan commented Jul 31, 2021

Done 👌

@jnbrunet jnbrunet merged commit 06824e8 into sofa-framework:master Jul 31, 2021
@guparan guparan added this to the v21.06 milestone Oct 26, 2021
@guparan guparan deleted the fix_fileformat_error branch November 18, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants