[SofaGL] Created persistent vparams and drawtool #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix to avoid a bad memory leak.
Contributor
Author
|
I just realized this module has already been included in the latest sofa binaries... I found that the memory leak here was really bad when using my python GUI tools and refreshing at like 20 Hz. Maybe this fix (or a better one) can get squeezed in? |
Contributor
|
Thanks a lot @psomers3 👍 👍 👍 for fixing this source of possible memory leak. Thanks for the contribution, we would glad to welcome you at the SOFA Week 2021! It could be the opportunity to present your work and your QSofaGLViewTools 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to avoid a bad memory leak.