Skip to content

Fix sites-packages copy/symlink when using intree #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnbrunet merged 1 commit into from
Aug 26, 2021
Merged

Fix sites-packages copy/symlink when using intree #166

jnbrunet merged 1 commit into from
Aug 26, 2021

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Aug 24, 2021

All in the title, (on linux) it was symlinking with an incorrect path

@jnbrunet
Copy link
Contributor

jnbrunet commented Aug 25, 2021

Hey @fredroy , is it related to #163 (and its PR #164)? If so, could you review/update them first?

@fredroy fredroy mentioned this pull request Aug 25, 2021
Closed
@jnbrunet jnbrunet merged commit 246d158 into sofa-framework:master Aug 26, 2021
@guparan guparan added this to the v21.06 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jnbrunet jnbrunet jnbrunet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: clean-fix pr: status ready

Projects

None yet

Milestone

v21.06

Development

Successfully merging this pull request may close these issues.

3 participants

@fredroy @jnbrunet @guparan