Skip to content

[Sofa.Core.Binding] Remove suprious exception handler in Binding_DataEngine #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 2 commits into from
Sep 28, 2021
Merged

[Sofa.Core.Binding] Remove suprious exception handler in Binding_DataEngine #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1b1fa
[Sofa.Core.Binding] Remove suprious exception handler in Binding_Data…
damienmarchal Sep 27, 2021
5fbff85
[SofaPython] Fix Typo
damienmarchal Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Plugin/src/SofaPython3/PythonEnvironment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ void executePython_(const T& emitter, std::function<void()> cb)
std::stringstream tmp;
tmp << "Unable to execute code." << msgendl
<< "Python exception:" << msgendl
<< " " << e.what();
<< " " << e.what()
<< PythonEnvironment::getPythonCallingPointString();
msg_error(emitter) << tmp.str();
}
}
Expand Down
11 changes: 4 additions & 7 deletions bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_DataEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,11 @@ void DataEngine_Trampoline::doUpdate()
{
PythonEnvironment::executePython(this, [this](){
py::object self = py::cast(this);
if (py::hasattr(self, "update")) {
if (py::hasattr(self, "update"))
{
py::object fct = self.attr("update");
try {
fct();
return;
} catch (std::exception& /*e*/) {
throw py::type_error(this->getName() + ": The DataEngine requires an update method with no parameter and no return type");
}
fct();
return;
}
throw py::type_error(this->getName() + " has no update() method.");
});
Expand Down