[Sofa.Core] Add BaseLink forwarding accessor. #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently accessing: ```python forcefield.mstate.position ``` does not work because forcefield.mstate is a link and thus a link does not have a "position" field. The working version consist to write ```object.mstate.getLinkedBase().position``` which is very cumbersome to write. This PR adds support for attribute forwarding through link allowing the firt approach.
The code in binding/Sofa/tests/Core/PythonRestShapeForceField.py seems outdated and not used anymore for testings. A fully working example is in examples/PythonRestShapeForceField.py So let's remove the one that is broken and not used.
jnbrunet
reviewed
Oct 21, 2021
jnbrunet
approved these changes
Oct 21, 2021
Fixe Co-authored-by: Jean-Nicolas Brunet <jnbrunet2000@gmail.com>
Contributor
Author
|
Many thank @jnbrunet for the review and suggestion. |
Contributor
|
One test is failing, the solution is just add |
Contributor
|
Test failing because test needs SofaDeformable to use RestShapeSpringForceField |
…ttribute-forwarding
…rding' into pr-add-baselink-attribute-forwarding
Contributor
Author
|
@hugtalbot, @fredroy tests are not failing anymore. |
Contributor
Author
|
Ready....so merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently accessing:
does not work because forcefield.mstate is a link and thus a link does not have a "position" field.
The working version consist to write
object.mstate.getLinkedBase().positionwhich is very cumbersome to write.This PR adds support for attribute forwarding through link allowing the firt approach.
The added feature is tested.