Skip to content

Conversation

@marques-bruno
Copy link
Member

Binding was not wrapping BaseNode* into a Sofa.Core.Node()

@hugtalbot
Copy link
Contributor

This means the function getRoot() was not available as is. Correct ?
The error was about : Node::getRoot am I understanding the binding correctly ?

@marques-bruno
Copy link
Member Author

This means the function getRoot() was not available as is. Correct ?
The error was about : Node::getRoot am I understanding the binding correctly ?

Yeah, the binding was returning a pointer without wrapping it around a pybind11 binding class, thus calling getRoot() would return an unusable pointer.

@marques-bruno marques-bruno merged commit 4ce2260 into sofa-framework:master May 28, 2020
@guparan guparan added this to the v20.12 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants