[SofaBaseLinearSolver] CGLinearSolver must call super init() to check required Data

[alxbilger]

CGLinearSolver::init() did not call init() of its base class. The result is that the check of the required Data, which is in BaseObject::init(), is never called. CGLinearSolver has required Data, therefore the error never triggered when one of the required Data was not set.

[ci-depends-on https://github.com/sofa-framework/Compliant/pull/4]
[ci-depends-on https://github.com/sofa-framework/Flexible/pull/3]
[ci-depends-on https://github.com/sofa-framework/SofaPython/pull/2]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/211]

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[alxbilger]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG 3a11f7365fa08c998fb4e07e23fc64f50233a273

[sofabot]

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG 3a11f7365fa08c998fb4e07e23fc64f50233a273

[hugtalbot]

Cool @alxbilger so if there is Required data and in Inherit::init() is called then the error gets not triggered. Correct?
We should investigate other components with this Required feature.

[sofabot]

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG 3a11f7365fa08c998fb4e07e23fc64f50233a273

[alxbilger]

Cool @alxbilger so if there is Required data and in Inherit::init() is called then the error gets not triggered. Correct? We should investigate other components with this Required feature.

That's the opposite: to catch an error if a required Data is missing, the component must call Inherit::init().

[alxbilger]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG fc5b448a5de22989477f6cde08d9b58d322a02ae
• Merge or close Missing required Data SofaPython#2
  For this build, SofaPython/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython
  GIT_TAG 8b5787f459de8ad885af8a3710333308f1853999
• Merge or close Missing required Data SofaPython3#211
  For this build, SofaPython3/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython3
  GIT_TAG ec9320ca0a3bec4ffc5e55abe5cd099ccdbff18f

[fredroy]

few CUDA scenes are failing, all with the messages [ERROR] [CGLinearSolver(cGLinearSolver1)] Required data "threshold" has not been set. (Current value is 1e-05) so I suppose these scenes must be updated too

[alxbilger]

few CUDA scenes are failing, all with the messages [ERROR] [CGLinearSolver(cGLinearSolver1)] Required data "threshold" has not been set. (Current value is 1e-05) so I suppose these scenes must be updated too

@fredroy ok I did not catch them. Thanks

[sofabot]

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG 26efcf7698a861e6df66a6b30b7318725df14f9d
• Merge or close Missing required Data SofaPython#2
  For this build, SofaPython/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython
  GIT_TAG 8b5787f459de8ad885af8a3710333308f1853999
• Merge or close Missing required Data SofaPython3#211
  For this build, SofaPython3/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython3
  GIT_TAG ec9320ca0a3bec4ffc5e55abe5cd099ccdbff18f

[sofabot]

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

• Merge or close Missing required Data Compliant#4
  For this build, Compliant/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Compliant
  GIT_TAG aa799839804a3860135eb30c88ab8c39bf388ec1
• Merge or close Missing required Data Flexible#3
  For this build, Flexible/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/Flexible
  GIT_TAG fbc130904462023496cbd330c7d815f0dfd95af1
• Merge or close Missing required Data SofaPython#2
  For this build, SofaPython/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython
  GIT_TAG ac7e23fb6aec5979c97b84a4feecdbb9dd340256
• Merge or close Missing required Data SofaPython3#211
  For this build, SofaPython3/ExternalProjectConfig.cmake.in will be edited by builders with
  GIT_REPOSITORY https://github.com/sofa-framework/SofaPython3
  GIT_TAG ec9320ca0a3bec4ffc5e55abe5cd099ccdbff18f

[guparan]

CI looks happy, I'll merge the dependent PRs 👍

[guparan]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #11.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

[alxbilger]

I think we're done. Can you check again @guparan @fredroy ?