Skip to content

Conversation

@epernod
Copy link
Contributor

@epernod epernod commented Feb 28, 2025

All backward compatibilities end-date are more than 1 year old.
(v20.12) for the headers and v23.12 for the methods writeMsh


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 28, 2025
@fredroy
Copy link
Contributor

fredroy commented Mar 5, 2025

[ci-build][with-all-tests]

@bakpaul bakpaul added the pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. label Mar 5, 2025
@hugtalbot
Copy link
Contributor

This PR will surely conflict with #5245 let's postpone the merge but everything looks good to us 👍

@epernod epernod force-pushed the inf_2025_05_clean_deprecated branch from 2209d4f to cd554fb Compare March 10, 2025 16:49
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. labels Mar 12, 2025
@hugtalbot hugtalbot merged commit 8ed18dd into sofa-framework:master Mar 12, 2025
17 checks passed
@epernod epernod deleted the inf_2025_05_clean_deprecated branch March 12, 2025 13:48
@hugtalbot hugtalbot added this to the v25.06 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants