Skip to content

Conversation

@YoEnte
Copy link
Collaborator

@YoEnte YoEnte commented Mar 13, 2025

Description

There was a bug about the swap carrot card, with the "not after swap card in last two turns" rule, because a check for market fields has been missing. using it after buying is legal.
I split up the check and needed the current turn distance to calculate if the player is now on market or hare field.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested manually on gui server
Added/Modified Swap Carrot Unit Tests
Adapted all other card test to the new changes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@YoEnte YoEnte requested a review from maxblan March 13, 2025 21:14
@maxblan maxblan merged commit b038194 into master Mar 15, 2025
1 check passed
@YoEnte YoEnte deleted the swap-carrots-bug branch August 12, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants