-
Notifications
You must be signed in to change notification settings - Fork 2
Uv build #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uv build #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Hugloss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces uv as the recommended package manager for the project, streamlining dependency management and application execution. It aims to simplify the setup process for new and existing contributors by leveraging uv's efficiency.
Highlights
- uv Integration: The project now officially supports and recommends uv for dependency management and running the application, offering a faster and more modern alternative to traditional pip workflows.
- pyproject.toml Adoption: A new pyproject.toml file has been added to centralize project metadata and dependency declarations, aligning with modern Python packaging standards.
- Updated Documentation: The README.md has been updated to include clear instructions on how to install uv, synchronize dependencies, and run the application using uv commands.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces uv for dependency management and running the application, which is a great improvement for speed and reliability. The new pyproject.toml is well-structured to handle the project's dependencies, including the git dependency for eval7. My feedback focuses on improving the clarity of the updated instructions in the README.md and a minor formatting fix in pyproject.toml.
| Using [uv](https://github.com/astral-sh/uv) (recommended — fast Python package manager) | ||
| Can also use `pip install uv` | ||
|
|
||
| Install dependencies from pyproject.toml | ||
| `uv sync` | ||
|
|
||
| Run the application | ||
| `uv run streamlit run app.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new instructions for uv are a great addition. To improve clarity for new users, I suggest restructuring this section with clear headings and placing shell commands in fenced code blocks. This makes the setup process easier to follow and the commands easier to copy.
| Using [uv](https://github.com/astral-sh/uv) (recommended — fast Python package manager) | |
| Can also use `pip install uv` | |
| Install dependencies from pyproject.toml | |
| `uv sync` | |
| Run the application | |
| `uv run streamlit run app.py` | |
| Using [uv](https://github.com/astral-sh/uv) is the recommended way to set up this project. | |
| **1. Install uv** | |
| If you don't have it, install it via pip: | |
| ```bash | |
| pip install uv |
2. Install dependencies
uv sync3. Run the application
uv run streamlit run app.py|
|
||
| # Tell uv what to preinstall in eval7's isolated build env | ||
| [tool.uv.extra-build-dependencies] | ||
| eval7 = ["Cython"] No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple way to make it run with uv