-
Notifications
You must be signed in to change notification settings - Fork 8
feat: 멘토 지원서 대학교 매핑 기능, 대학 선택 상태 페이징 조건 추가 #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sukangpunch
wants to merge
9
commits into
solid-connection:develop
Choose a base branch
from
sukangpunch:feat/579-admin-map-university-to-mentor-applications
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
58623df
feat: 멘토 지원서 검색 조건에 UniversitySelectType 추가
sukangpunch 05d474b
feat: 어드민 멘토 지원서 페이징 조회 응답에 UniversitySelectType 추가
sukangpunch bb75aa8
test: 멘토 지원서 조회 테스트 추가
sukangpunch 536c4c6
feat: 멘토 지원서에 대학 매핑 기능 추가
sukangpunch d6862f7
test: 멘토 지원서 대학 매핑 테스트 추가
sukangpunch 7858e26
refactor: 의미 없는 import 제거
sukangpunch 56808c2
refactor: 리뷰 내용 반영
sukangpunch 4d23a49
refactor: Service 레이어의 검증 로직을 도메인으로 이동
sukangpunch 7df44a0
test : assertAll 로 검증 그룹화
sukangpunch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
.../java/com/example/solidconnection/admin/dto/MentorApplicationAssignUniversityRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.example.solidconnection.admin.dto; | ||
|
|
||
| import jakarta.validation.constraints.NotNull; | ||
|
|
||
| public record MentorApplicationAssignUniversityRequest( | ||
| @NotNull(message = "대학 ID 는 필수입니다.") | ||
| Long universityId | ||
| ) { | ||
|
|
||
| } |
2 changes: 2 additions & 0 deletions
2
src/main/java/com/example/solidconnection/admin/dto/MentorApplicationResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
src/main/java/com/example/solidconnection/admin/dto/MentorApplicationSearchCondition.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| package com.example.solidconnection.admin.dto; | ||
|
|
||
| import com.example.solidconnection.mentor.domain.MentorApplicationStatus; | ||
| import com.example.solidconnection.mentor.domain.UniversitySelectType; | ||
| import java.time.LocalDate; | ||
|
|
||
| public record MentorApplicationSearchCondition( | ||
| MentorApplicationStatus mentorApplicationStatus, | ||
| String keyword, | ||
| LocalDate createdAt | ||
| LocalDate createdAt, | ||
| UniversitySelectType universitySelectType | ||
| ) { | ||
|
|
||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도메인 메서드와 이를 사용하는 서비스 메서드 모두
APPROVED,REJECTED인 지원서에도 대학 추가가 가능한 것으로 보입니다(관련 검증을 찾을 수 없습니다). 만약PENDING상태의 지원서만 대학이 추가되어야 한다면 관련 검증이 있어야 할 거 같습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whqtker 말씀 하신 내용 적용 하였습니다!