Remove CdrDimensionType values not applicable to ChargingPeriods from a CDR #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
According to the docs, there are certain values for CdrDimensionType that are only applicable if the ChargingPeriod belongs to a Session.
https://github.com/ocpi/ocpi/blob/release-2.2-bugfixes/mod_cdrs.asciidoc#143-cdrdimensiontype-enum
https://github.com/ocpi/ocpi/blob/release-2.2.1-bugfixes/mod_cdrs.asciidoc#143-cdrdimensiontype-enum
This change removes the CdrDimensionType's values not applicable to a CDR.
I've removed the import of the class ChargingPeriod inside Sessions and duplicated the object inside to allow me to have two different representations of CdrDimensionType.
I'm sure there is a cleaner way to do this but I'm not that proficient with zod.
Suggestions or changes are more than welcome.