Add OCPI 2.3 schema support #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces an implementation of OCPI 2.3 into the schema set. It includes all core modules plus the new Booking module.
A couple of points I would like feedback on:
1. Many structures in 2.3 are identical to 2.2.1. For now, I duplicated these classes under the 2.3 tree to keep versions isolated.
2. There is a new concept in OCPI 2.3 called OpenEnum. Any enum marked with this has a bunch of predefined values but also allows random values. I've implemented it as a union of whatever the recommended values are, plus any kind of string.
I'm more than open to changes. I'm pretty sure there are things I may have missed, especially in the two new modules.