Accept DOMDocument input #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartbutler
force-pushed
the
feat/convert-document
branch
from
7b0785b to
4d49be6
Compare
|
@soundasleep: Have you seen this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing can be slow and sometimes we need the intermediate DOMDocument as well (to process links in code outside Html2Text, for instance).
This PR restructures convert() so that it can be easily called as two separate functions while returning the DOMDocument to the caller. is_office_document has also been moved into the options array with sensible default behavior.
There should be no side-effects of this refactor for users.