fix: dynamic file upload icon and size display with accessibility imp… #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovements - Add dynamic icon rendering based on selected file type (image, audio, video, document, all_types) - Replace static file size text with dynamic value from builder configuration - Wrap upload area with full-width label for better accessibility - Optimize file type groups lookup to avoid duplicate function calls - Improve screen reader support and keyboard navigation
- Implement dynamic icon rendering for various file types in the upload area - Update SCSS to improve layout and hover effects for file thumbnails - Add accessibility features including pointer events adjustments and improved file name display - Ensure consistent styling for file icons and names to enhance user experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rovements
PR Type
What kind of change does this PR introduce?
Description
Fixes the File Upload custom field to dynamically display icons and file size based on builder configuration, and improves accessibility by wrapping the upload area with a full-width label.
Changes
Dynamic Icon Display: File upload field now shows appropriate icons based on selected file type:
Dynamic File Size: Replaces static "1600×1200 or larger" text with dynamic file size from builder configuration (e.g., "Maximum file size: 2mb")
Accessibility Improvements:
Testing
Files Changed
templates/listing-form/custom-fields/file.phpRelated Issues
Fixes issue where File Upload field showed static icon and text regardless of builder configuration.
Live Video
https://www.loom.com/share/9288662717d7477cb7e811ffa3bc6b31
Any linked issues
Fixes #
#2443
https://taiga-sovware-u10698.vm.elestio.app/project/directorist/issue/2172
Checklist