Make PR check fails when find invalid SPDX 2.x SBOM #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of build it from latest source Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com> Co-Authored-By: Gary O'Neall <gary@sourceauditor.com>
Add set -e Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail..com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
changed the title
Use --quiet option to disable spinner and make the log smaller Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
JPEWdev
approved these changes
Apr 8, 2025
Contributor
Author
|
Reviewed during 2025-04-08 Tech Team meeting . |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Contributor
Author
|
Update tools-java version to 2.0.1 |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix two issues in SPDX 2.x validation step in the PR check workflow:
tools-java.jar Verifyoutsidefind -exec, so the Verify exit code is not hidden and can be used to failed workflow.This PR also add
--quietoption tospdx3-validateto disable its spinner and make the run log more compact and easier to read.--
Note that this PR currently failed the PR check because there are 3 SBOMs that don't pass the SBOM validation. These following issues have to be fixed before the check can get a pass: