Skip to content

Add dwcConcept and dwcDescription to schema config field #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarolineDenis wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add dwcConcept and dwcDescription to schema config field #6560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53a5cd5
Add dwcConcept and dwcDescription to schema config field
CarolineDenis May 29, 2025
d8eab44
Make dwcConcept and desc readonly
CarolineDenis May 29, 2025
d58cf4b
Comment
CarolineDenis May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions specifyweb/frontend/js_src/lib/components/DataModel/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5212,6 +5212,8 @@ export type SpLocaleContainerItem = {
readonly type: string | null;
readonly version: number | null;
readonly webLinkName: string | null;
readonly dwcConcept: string | null;
readonly dwcDescription: string | null;
};
readonly toOneDependent: RR<never, never>;
readonly toOneIndependent: {
Expand Down
51 changes: 50 additions & 1 deletion specifyweb/frontend/js_src/lib/components/SchemaConfig/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,16 @@ export function SchemaConfigField({
readonly field: LiteralField | Relationship;
readonly item: SerializedResource<SpLocaleContainerItem> & WithFetchedStrings;
readonly onChange: (
field: 'desc' | 'isHidden' | 'isRequired' | 'name',
field:
| 'desc'
/*
* To uncomment if we want to allow redefinition
* | 'dwcConcept'
* | 'dwcDescription'
*/
| 'isHidden'
| 'isRequired'
| 'name',
value: boolean | string
) => void;
readonly onFormatted: (format: ItemType, value: string | null) => void;
Expand Down Expand Up @@ -65,6 +74,46 @@ export function SchemaConfigField({
onValueChange={(value): void => handleChange('desc', value)}
/>
</Label.Block>
{/* Add back after testing*/}
{/* {item.dwcConcept !== null && ( */}
<Label.Block>
{schemaText.dwcConcept()}
<Input.Text
isReadOnly
/*
* MaxLength={maxSchemaValueLength}
* required
* To chnage once we have item.dwcConcept !== null &&
*/
value={item.dwcConcept === null ? 'DWC Concept' : item.dwcConcept}
/*
* To uncomment if we want to allow redefinition
* onValueChange={(value): void => handleChange('dwcConcept', value)}
*/
/>
</Label.Block>
{/* )} */}
{/* Add back after testing*/}
{/* {item.dwcDescription !== null && ( */}
<Label.Block>
{schemaText.dwcDescription()}
<AutoGrowTextArea
className="resize-y"
isReadOnly
/*
* MaxLength={maxSchemaValueLength}
* To chnage once we add the condition rendering
*/
value={
item.dwcDescription === null ? 'DwC desc' : item.dwcDescription
}
/*
* To uncomment if we want to allow redefinition
* onValueChange={(value): void => handleChange('dwcDescription', value)}
*/
/>
</Label.Block>
{/* )} */}
<Label.Block>
{schemaText.fieldLength()}
<Input.Integer isReadOnly value={field.length ?? ''} />
Expand Down
Loading
Loading