Skip to content

Fix: Repeated Warning Message "Preparation count cannot be negative" #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iwantexpresso wants to merge 11 commits into
base: main
Choose a base branch
from
+10 −3
Open

Fix: Repeated Warning Message "Preparation count cannot be negative" #7595

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b636151
added check if min attribute is present then runs either save blocker…
Iwantexpresso Dec 18, 2025
b838053
Lint code with ESLint and Prettier
Iwantexpresso Dec 18, 2025
7f72143
Merge branch 'main' into issue-7156
Iwantexpresso Dec 18, 2025
3b01971
Lint code with ESLint and Prettier
Iwantexpresso Dec 18, 2025
3a1a46d
removed previous flimsy implementation and added a more robust check …
Iwantexpresso Dec 30, 2025
09bf4aa
Lint code with ESLint and Prettier
Iwantexpresso Dec 30, 2025
b135731
Merge branch 'main' into issue-7156
Iwantexpresso Dec 30, 2025
3d69934
Lint code with ESLint and Prettier
Iwantexpresso Dec 30, 2025
d664be4
used existing hasNativeErros functions instead of previous custom const
Iwantexpresso Jan 7, 2026
1da5df4
comment and newline cleanup
Iwantexpresso Jan 7, 2026
52854ad
Merge branch 'main' into issue-7156
Iwantexpresso Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions specifyweb/frontend/js_src/lib/hooks/useValidation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';

import { InFormEditorContext } from '../components/FormEditor/Context';
import type { Input } from '../components/Forms/validationHelpers';
import { isInputTouched } from '../components/Forms/validationHelpers';
import { hasNativeErrors, isInputTouched } from '../components/Forms/validationHelpers';
import { listen } from '../utils/events';
import type { RA } from '../utils/types';

Expand Down Expand Up @@ -97,8 +97,15 @@ export function useValidation<T extends Input = Input>(
// Do not steal focus when form rendering the form in the form editor
if (isInFormEditor) return;

// Empty string clears validation error
input.setCustomValidity(joined);
/*
* Empty string clears validation error
* simple check for HTML validation, through hasNativeErrors and prevents from both Validators to be active simultaneously
*/
if (hasNativeErrors(input)) {
input.setCustomValidity('');
} else {
input.setCustomValidity(joined);
}

if (
type === 'focus' ||
Expand Down