-
Notifications
You must be signed in to change notification settings - Fork 94
Switch the quickstart tutorial to use k8s_psat #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db48c55 to
db816ec
Compare
9d89734 to
f91e881
Compare
For me this gets the set of commands for my user shell, not the shell running the script. Since we know we run the script as bash, tell that to minikube. Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
rturner3
reviewed
Mar 8, 2025
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
rturner3
approved these changes
Mar 10, 2025
CarloSegat
pushed a commit
to CarloSegat/spire-tutorials
that referenced
this pull request
Jan 14, 2026
* Specify shell when fetching docker-env For me this gets the set of commands for my user shell, not the shell running the script. Since we know we run the script as bash, tell that to minikube. Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Switch from k8s_sat to k8s_psat Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Upgrade to SPIRE 1.11.1 Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Also fix the node alias entry Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Increase log lookback window size Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Update more lookback windows Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Update to 1.11.2 now that it's available Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Also update version in docker-compose Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * trim whitespace from jwt-svid Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Update workflow base image and go version Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Remove cgroup matching, it's no longer needed Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Wait for the servers to be ready Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Wait for the right server Signed-off-by: Sorin Dumitru <sorin@returnze.ro> --------- Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #138