k8s: add fsGroup to server-statefulset #143
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tmaciejewski Could you also add the DCO to the commit (the Signed-Of-By)? I think the failed tests might be flaky, I can look into those. |
See: spiffe/spire-examples#108 Signed-off-by: Tomasz Maciejewski <tmaciejewsk@gmail.com>
Contributor
Author
|
Updated the commit. Thanks! |
sorindumitru
approved these changes
Apr 23, 2025
Contributor
sorindumitru
left a comment
sorindumitru
left a comment
There was a problem hiding this comment.
Thanks, @tmaciejewski! LGTM
CarloSegat
pushed a commit
to CarloSegat/spire-tutorials
that referenced
this pull request
Jan 14, 2026
See: spiffe/spire-examples#108 Signed-off-by: Tomasz Maciejewski <tmaciejewsk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #142