Fix issues with updating value lists in parameter definition items #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soininen
force-pushed
the
dont_backup_unchanged_items
branch
from
3d4b7a1 to
f7dcbb4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 85.65% 85.67% +0.02%
==========================================
Files 81 81
Lines 11012 11022 +10
Branches 1617 1622 +5
==========================================
+ Hits 9432 9443 +11
Misses 1222 1222
+ Partials 358 357 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This wasn't really a bug, just unoptimal. The caches should be cleared when the update contains the value field, not when the merged item has it because the merged item always includes the field.
Due to an oversight, it wasn't possible to e.g. set value list back to None for parameter definition. This enables such operations. Altough a rare use case, this was very much possible when doing rollback.
Changing value list of a definition that has values is prohibited. However, we only checked if parameter_value_list_id was updated. Now we chack parameter_value_list_name, too.
soininen
force-pushed
the
dont_backup_unchanged_items
branch
from
f7dcbb4 to
9ac9711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
parameter_value_list_name, back to Noneparameter_value_list_nameon a parameter definition which had values.No associated issue.
Checklist before merging