Skip to content

Conversation

@millert
Copy link

@millert millert commented May 9, 2021

The y.tab.c file equivalent now includes the generated header so
we need to update the path in the .c files when renaming the header.

The y.tab.c file equivalent now includes the generated header so
we need to update the path in the .c files when renaming the header.
@cooljeanius
Copy link

Have you tested this with various different sed variants? BSD sed and GNU sed can sometimes behave differently in cases like these...

@millert
Copy link
Author

millert commented Oct 29, 2023

I only used POSIX sed features, no extensions. Portability issues crop up with things like sed -i (edit in place) and sed -E (extended regex).

@cooljeanius
Copy link

I only used POSIX sed features, no extensions. Portability issues crop up with things like sed -i (edit in place) and sed -E (extended regex).

OK, thanks. In that case, LGTM, although I'm just an onlooker, and haven't tested it myself...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants