-
Notifications
You must be signed in to change notification settings - Fork 436
Analytic Enhancements and Fixes #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+868
−965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detections/endpoint/dllhost_with_no_command_line_arguments_with_network.yml
Show resolved
Hide resolved
detections/endpoint/rundll32_with_no_command_line_arguments_with_network.yml
Show resolved
Hide resolved
patel-bhavin
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial effort to address some of the problematic rules referenced in #3809. The TL;DR is that some rules are relying on filtering later which hinders their performance a lot. Some are by design due to usage of lookups or features such as regex that are not available in tstats for example.
From the original list i have fixed what is possible and still working on the some of the rest.
Updated Analytics [8]
Suspicious Email Attachment Extensions- Added additional output fields in thebyclause, as well as updated the RBA message.DLLHost with no Command Line Arguments with Network- Added a process filter in the process events search to reduce the sample size, instead of filtering via regex later.Rundll32 with no Command Line Arguments with Network-SearchProtocolHost with no Command Line with Network-Single Letter Process On Endpoint- Removed the usage of the regex instead opted for enumerating all possible values in the tstats. This will improve performance and will not lose any coverage.System Processes Run From Unexpected Locations- Added an additional filter location.Windows Command and Scripting Interpreter Hunting Path Traversal- Added an additional filter in the search, since it does not make sense to look for all processes and then filter them.Windows LOLBAS Executed Outside Expected Path- AddedWinSxSas a new filter.Lookup Updates [3]
lookups/is_suspicious_file_extension_lookup.csv- Since this lookup is only used in theSuspicious Email Attachment Extensionsanalytic. I updated it and reduced the search space to only thing that actually matter based on collected stats from our telemetry.lookups/is_windows_system_file.csv- Removed a lot of unnecessary filenames and reduced the search space.lookups/lolbas_file_path.csv