Skip to content

refactor(StaxStreamXMLReader): remove duplicate ifs #35869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RealTake wants to merge 1 commit into from
Closed

refactor(StaxStreamXMLReader): remove duplicate ifs #35869

RealTake wants to merge 1 commit into from
+14 −14

Conversation

@RealTake
Copy link

@RealTake RealTake commented Nov 22, 2025

What was done

  • Removed unnecessary duplicate if conditions in the codebase.
  • Ensured that no existing functionality was affected by the changes.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 22, 2025
@bclozel
Copy link
Member

bclozel commented Dec 17, 2025

Build fails and the DCO is not signed, we cannot accept this contirbution and I don't it's worth spending time on such a minimal change.

@bclozel bclozel closed this Dec 17, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RealTake @bclozel @spring-projects-issues