-
Notifications
You must be signed in to change notification settings - Fork 53
feat: ⬆️ upgrade apalis version #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
First of all only |
|
Waiting for version 1.0.0 release. |
|
I did a release yesterday. |
|
Spring-RS code has strict clippy checks; many upstream apalis-postgres code snippets still fail Spring-RS's clippy checks. |
|
You are trying to bump a major version without looking at the changelog: This will never work because its v0.7 but not supported in v1.0 Please see https://github.com/apalis-dev/apalis/blob/main/CHANGELOG.md#breaking-changes for a start |
|
PS, There are breaking changes that are not documented so I might discourage updating to v1 yet. Please wait for the RC versions. I am hopeful to start releasing them tonight. I will update you when I do. |
|
@geofmureithi I added the apalis-amqp dependency, but I'm getting an error. error[E0437]: type `Compact` is not a member of trait `Backend`
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/apalis-amqp-1.0.0-alpha.1/src/lib.rs:169:5
|
169 | type Compact = Vec<u8>;
| ^^^^^^^^^^^^^^^^^^^^^^^ not a member of trait `Backend`
error[E0437]: type `Codec` is not a member of trait `Backend`
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/apalis-amqp-1.0.0-alpha.1/src/lib.rs:172:5
|
172 | type Codec = JsonCodec<Vec<u8>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a member of trait `Backend`
For more information about this error, try `rustc --explain E0437`.
error: could not compile `apalis-amqp` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish... |
|
Hey,
I had taken a small break for the last two weeks. I am back on this and
will start releasing the release candidate versions. Also I will pick up
this issue and do a PR for you. Thanks for your patience.
|
You are using beta.3 and we are already in rc.1 |
|
@holmofy The issues you are facing are described here |
|
|
@holmofy this seems to be related to the There is a PR on this: apalis-dev/apalis-postgres#39 Should be resolved by Monday. |
- Update apalis from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-workflow from 0.1.0-rc.1 to 0.1.0-rc.2 - Add amqp feature to spring-apalis feature flags - Uncomment and enable apalis-amqp optional dependency - Export apalis_amqp module when amqp feature is enabled - Clean up inline comments from dependency declarations for consistency
|
@holmofy I have released rc-2 for relevant crates |
- Update apalis-redis from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-amqp from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-postgres from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-mysql from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-sqlite from 1.0.0-rc.1 to 1.0.0-rc.2 - Update apalis-cron from 1.0.0-rc.1 to 1.0.0-rc.2 - Align all apalis backend dependencies with latest release candidate version
- Remove unused `axum::http::StatusCode` import from middleware module - Cleanup unnecessary dependencies to reduce code clutter
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
The problem still exists. @geofmureithi |
Please try that and let me know |
- Update apalis-board from 1.0.0-rc.1 to 1.0.0-rc.2 - Align apalis-board version with other apalis dependencies - Ensure consistency across apalis ecosystem versions
…ndencies - Add explicit "time" feature configuration for apalis-postgres, apalis-sqlite, and apalis-mysql dependencies - Disable default features for database adapters to reduce dependency bloat - Export spring_sqlx module when any SQL database feature is enabled - Refactor plugin dependencies condition from `any()` to `all(any(), not(redis))` to prevent duplicate dependency declarations - Improve conditional compilation logic for better feature flag handling
- Add CARGO_TERM_COLOR and CARGO_INCREMENTAL environment variables to clippy workflow - Add CARGO_INCREMENTAL environment variable to publish workflow - Add CARGO_TERM_COLOR and CARGO_INCREMENTAL environment variables to test-coverage workflow - Standardize cargo build configuration across all CI/CD pipelines for consistent output and improved build performance
- Remove redundant target directory cache step from test-coverage.yaml - Simplify workflow by relying on cargo environment variable configuration - Reduce workflow complexity and potential cache invalidation issues
- Disable default features for apalis-postgres, apalis-mysql, and apalis-sqlite in root Cargo.toml - Remove redundant default-features = false from spring-apalis database dependencies - Simplify feature configuration by inheriting default-features = false from workspace - Consolidate time feature specification across all database backend crates - Reduce configuration duplication and improve maintainability
|
@holmofy Great this has been resolved |
|
Yeah, I'll complete the relevant documentation. |
No description provided.